Export VariantGroups and PatternOptions types from @vanilla-extract/recipes#1204
Open
HorusGoul wants to merge 1 commit intovanilla-extract-css:masterfrom
Open
Export VariantGroups and PatternOptions types from @vanilla-extract/recipes#1204HorusGoul wants to merge 1 commit intovanilla-extract-css:masterfrom
HorusGoul wants to merge 1 commit intovanilla-extract-css:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 429bae7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2a61143 to
429bae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like in #694, I need to create a wrapper for the
recipe()function. The solution provided in that issue doesn't solve the actual problem.In my case, something else is needed. The proper type is the same type
recipeuses:I need to be able to do precisely that, process the options parameter, and pass it to
recipe. Not doing it this way would make the API for the consumer of mywrappedRecipefunction not configurable with a type parameter likerecipe.In that same issue, someone mentions the reason behind not exposing these types:
Good, this makes sense, but this is part of the public API; I should be able to generate the
PatternOptionsin any way I like, with complete type safety, which I won't have unless I can doPatternOptions<MyVariants>PatternOptionsandVariableGroupsare already public but not exported. If the format forPatternOptionchanges at some point or we remove something, it will be a breaking change and will require a major bump for the recipes package.So, in the hopes of reopening this discussion and making it easy to fix the problem, I've opened this PR 😄