Begin resolving type annotation issues#282
Open
kurtmckee wants to merge 1 commit intovalkey-io:mainfrom
Open
Conversation
Signed-off-by: Kurt McKee <contactme@kurtmckee.org>
Collaborator
|
Thanks. I'm currently handling it in #265. I'll check your PR properly once my PR is merged and we can continue from there. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Description of change
When mypy is run with its current settings in
.mypy.ini, there are just short of 1,000 warnings and failures. This PR begins the work of fixing these mypy failures.A new CI job,
test-type-annotations, is introduced. It is added to theneedsrequirements for the test suite matrix.The mypy settings are migrated from
.mypy.initopyproject.toml.This is desirable because in the INI config file doesn't support a list of modules to override; the TOML format supports a compact list of globbed modules in the
tool.mypy.overridessection, which is easier to read and maintain.An initial batch of files' type annotations are fixed.
There are still many, many type annotation issues to address, but this initial work introduces the testing infrastructure to support ongoing improvements and fixes.