Skip to content

Conversation

@nijdarshan
Copy link

Summary

  • Add targetPath to GitConfig for specifying values file location
  • Enables multiple envs in single repo (e.g. envs/dev/, envs/prod/)
  • Non-breaking: empty default preserves existing behavior

Changes

  • Add TargetPath to GitConfig struct
  • Prefix values files with targetPath
  • Add Path to multi-source valuesSource
  • Add global.targetPath helm param
  • Add tests

Test plan

  • make test passes
  • make generate manifests runs clean
  • CI passes

enables multiple envs in single repo via targetPath
(e.g. envs/dev/, envs/prod/) instead of branches
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nijdarshan
Once this PR has been reviewed and has the lgtm label, please assign mhjacks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

Hi @nijdarshan. Thanks for your PR.

I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant