-
Notifications
You must be signed in to change notification settings - Fork 14
Add documentation on values for the Supply Chain use case #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
minmzzhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the patch method, shall we create patch files for all the optional layer1 applications?
Signed-off-by: Manuel Lorenzo <[email protected]>
05adac7 to
adb4dfc
Compare
This is an option I'm proposing. Creating patches is simple and quick to implement. The downside is that it will require more maintenance if we make a lot of changes to the |
sabre1041
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few suggestions
docs/supply-chain.md
Outdated
|
|
||
| ### Setting up the values | ||
|
|
||
| We've seen the components we'll use in this use case. To configure them, we must add (uncomment) these parameters to the `values-hub.yaml` file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "We've see the components we'll use in this use case" mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am referring to the components described in the previous sections (Main and Supporting Components): RHTAS, RHTPA, ZTWIM, Quay, MCO, and Tekton.
Co-authored-by: Andrew Block <[email protected]>
Co-authored-by: Andrew Block <[email protected]>
Co-authored-by: Andrew Block <[email protected]>
Co-authored-by: Andrew Block <[email protected]>
Co-authored-by: Andrew Block <[email protected]>
Co-authored-by: Andrew Block <[email protected]>
Signed-off-by: Manuel Lorenzo <[email protected]>
This PR adds documentation on which values should be uncommented in the
values-hub.yamlfile to set up the Supply Chain use case.I've also added a patch file so it can be applied and configured quickly.
Under review