Open
Conversation
lw64
requested changes
Jan 31, 2024
Contributor
lw64
left a comment
lw64
left a comment
There was a problem hiding this comment.
Thanks and nice improvement!
Author
|
Are there any other problems? Can they be merged? @lw64 |
lw64
approved these changes
Feb 21, 2024
Author
Prince781
reviewed
Mar 30, 2024
Member
Prince781
left a comment
Prince781
left a comment
There was a problem hiding this comment.
If this is for supporting VSCode, it should be in the vala-vscode plugin. We don't want to use VSCode settings unless we're actually running the language server through VSCode.
added 2 commits
March 30, 2024 10:58
Prince781
added a commit
that referenced
this pull request
Apr 1, 2024
This introduces settings overrides (`EditorOptions`) passed from the editor to the server in the initialize() call. These overrides are just currently for the Meson backend. The intent is to have the vala-vscode extension send these options from the Meson VSCode extension to VLS. Closes #304 and #305.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.