Add possibility to change widgetset compilation style for superdevmode in command line#104
Add possibility to change widgetset compilation style for superdevmode in command line#104wbadam wants to merge 1 commit intovaadin:masterfrom
Conversation
|
|
|
How does this differ from using |
|
It doesn't differ, the style parameter currently isn't passed further to the Codeserver in vaadin-maven-plugin, i.e. The same is implemented in this commit in gwt-maven-plugin: gwt-maven-plugin/gwt-maven-plugin@5eb7189 but was never introduced here. |
|
I see, so it's missing a "superdevmode" keyword from the summary Reviewed 2 of 2 files at r1. Comments from Reviewable |
|
Yes, sorry, the ticket I opened (#103) does have the keyword but forgot to mention it in the PR Review status: Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. src/main/java/org/codehaus/mojo/gwt/shell/AbstractGwtShellMojo.java, line 92 at r1 (raw file):
Why make this protected instead of simply using getStyle() that also CompileMojo uses? Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion. src/main/java/org/codehaus/mojo/gwt/shell/AbstractGwtShellMojo.java, line 92 at r1 (raw file): Previously, hesara (Henri Sara) wrote…
Could do that as well if you prefer, I copied the changes from gwt-maven-plugin https://github.com/gwt-maven-plugin/gwt-maven-plugin/blob/master/src/main/java/org/codehaus/mojo/gwt/shell/AbstractGwtShellMojo.java#L80 Comments from Reviewable |
Resolves #103
This change is