fix: prevent deletion of app-shell-imports by frontend cleanup task#24118
Merged
mcollovati merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
`TaskRemoveOldFrontendGeneratedFiles` deletes files in the frontend generated folder that are not recognized as known generated files. The `app-shell-imports.js` and `app-shell-imports.d.ts` files were missing from the known files list, causing them to be deleted when `vaadinPrepareFrontend` runs without the index generation task, for example when IntelliJ IDEA triggers a Gradle compilation while the dev server is running with hot deploy. Add `APP_SHELL_IMPORTS_NAME` and `APP_SHELL_IMPORTS_D_TS_NAME` to the known files list. Also improve test coverage by verifying all known file types, including Hilla generated files. Related to #24108
|
Test Results 1 391 files 1 391 suites 1h 13m 48s ⏱️ Results for commit 0e823ef. |
caalador
approved these changes
Apr 15, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
…24118) `TaskRemoveOldFrontendGeneratedFiles` deletes files in the frontend generated folder that are not recognized as known generated files. The `app-shell-imports.js` and `app-shell-imports.d.ts` files were missing from the known files list, causing them to be deleted when `vaadinPrepareFrontend` runs without the index generation task, for example when IntelliJ IDEA triggers a Gradle compilation while the dev server is running with hot deploy. Add `APP_SHELL_IMPORTS_NAME` and `APP_SHELL_IMPORTS_D_TS_NAME` to the known files list. Also improve test coverage by verifying all known file types, including Hilla generated files. Related to #24108
Collaborator
|
Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 25.0, i have encountered the following issue. Can you take a look and pick it manually? |
vaadin-bot
added a commit
that referenced
this pull request
Apr 15, 2026
…24118) (CP: 25.1) (#24124) This PR cherry-picks changes from the original PR #24118 to branch 25.1. --- #### Original PR description > `TaskRemoveOldFrontendGeneratedFiles` deletes files in the frontend generated folder that are not recognized as known generated files. The `app-shell-imports.js` and `app-shell-imports.d.ts` files were missing from the known files list, causing them to be deleted when `vaadinPrepareFrontend` runs without the index generation task, for example when IntelliJ IDEA triggers a Gradle compilation while the dev server is running with hot deploy. > > Add `APP_SHELL_IMPORTS_NAME` and `APP_SHELL_IMPORTS_D_TS_NAME` to the known files list. Also improve test coverage by verifying all known file types, including Hilla generated files. > > Related to #24108 Co-authored-by: Marco Collovati <marco@vaadin.com>
mcollovati
added a commit
that referenced
this pull request
Apr 15, 2026
…24118) `TaskRemoveOldFrontendGeneratedFiles` deletes files in the frontend generated folder that are not recognized as known generated files. The `app-shell-imports.js` and `app-shell-imports.d.ts` files were missing from the known files list, causing them to be deleted when `vaadinPrepareFrontend` runs without the index generation task, for example when IntelliJ IDEA triggers a Gradle compilation while the dev server is running with hot deploy. Add `APP_SHELL_IMPORTS_NAME` and `APP_SHELL_IMPORTS_D_TS_NAME` to the known files list. Also improve test coverage by verifying all known file types, including Hilla generated files. Related to #24108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskRemoveOldFrontendGeneratedFilesdeletes files in the frontend generated folder that are not recognized as known generated files. Theapp-shell-imports.jsandapp-shell-imports.d.tsfiles were missing from the known files list, causing them to be deleted whenvaadinPrepareFrontendruns without the index generation task, for example when IntelliJ IDEA triggers a Gradle compilation while the dev server is running with hot deploy.Add
APP_SHELL_IMPORTS_NAMEandAPP_SHELL_IMPORTS_D_TS_NAMEto the known files list. Also improve test coverage by verifying all known file types, including Hilla generated files.Related to #24108