feat: add IntegerSlider, IntegerRangeSlider#9123
Merged
sissbruecker merged 4 commits intomainfrom Apr 15, 2026
Merged
Conversation
sissbruecker
commented
Apr 15, 2026
Contributor
Author
There was a problem hiding this comment.
For unit tests, I only added new suites for the basic properties of IntegerSlider and IntegerRangeSlider. Duplicating the other suites seemed a bit much and making them generic is also not trivial.
For integration tests I duplicated the existing ones. There weren't a lot of them and it seemed valuable to have an E2E test for the new variants.
vursen
reviewed
Apr 15, 2026
vursen
approved these changes
Apr 15, 2026
…a/com/vaadin/flow/component/slider/testbench/NumberRangeSliderElement.java Co-authored-by: Sergey Vinogradov <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
IntegerSliderandIntegerRangeSlideras alternative slider variants that use integer values for min, max, step and value properties.Also adds
IntegerSliderElementandIntegerRangeSliderElementTestBench elements for convenience.Part of #8863
Type of change