Open
Conversation
Member
manolo
commented
Apr 1, 2026
manolo
commented
- add GitHub Actions validation workflow
- fix local build issues with Flow frontend build
Force production frontend build in wtr.js and build.sh verify step to prevent flow:build-frontend from skipping npm install when it detects an existing bundle. Add pre-compile step after mergeITs to avoid incremental compilation wiping flow-build-info.json during the verify lifecycle. Clean stale Flow-generated files in mergeITs.js and create an empty package.json so that build-frontend preserves generated config files.
sissbruecker
reviewed
Apr 1, 2026
| GH_TOKEN: ${{ github.token }} | ||
| run: | | ||
| elements="${{ github.event.inputs.components || '' }}" | ||
| if [ -z "$elements" ] && [ "${{ github.event_name }}" = "pull_request" ]; then |
Contributor
There was a problem hiding this comment.
It looks like this would only detect changed components when checking pull requests. It would be good to also have this for checks running from the merge queue.
Related to that, the workflow also needs the respective merge queue trigger.
Replicate the TeamCity validation build as a GH Actions workflow. Single job runs: compile, unit tests, skip-ci check, mergeITs, pre-compile, WTR tests, Selenium setup, and integration tests.
checkout@v6, setup-java@v5, setup-node@v6, upload-artifact@v5
Use -q flag unless the workflow is re-run with debug enabled.
Use dorny/test-reporter to parse surefire and failsafe XML reports and create check runs with test summaries visible in the PR.
Support merge_group events so the workflow runs when PRs enter the merge queue. Component detection uses git diff for merge queue events since there is no PR number available for the GitHub API.
Replace manual docker pull/run/stop with a service container that starts automatically and maps port 4444.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.