Fix RBAC mappings for 'systems.profiles' namespace (bsc#1271963) - #12339
Open
cbbayburt wants to merge 2 commits into
Open
Fix RBAC mappings for 'systems.profiles' namespace (bsc#1271963)#12339cbbayburt wants to merge 2 commits into
cbbayburt wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes RBAC data for the systems.profiles namespace so package profile UI endpoints are properly grouped and described, and updates the system-details navigation to use the corrected namespace for the “Profiles” tab.
Changes:
- Add/seed missing package profile endpoints (CompareProfiles POST, CompareSystems GET/POST) and map them into
systems.profiles. - Move existing package profile endpoints from
systems.software.packagesintosystems.profiles(R/W split) and add namespace descriptions. - Update the system details navigation “Profiles” tab ACL to reference
systems.profiles.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| schema/spacewalk/upgrade/susemanager-schema-5.2.9-to-susemanager-schema-5.2.10/100-rbac-package-profiles.sql | Upgrade migration to set systems.profiles descriptions, move endpoint namespace mappings, and add missing endpoints/mappings. |
| schema/spacewalk/susemanager-schema.changes.cbbayburt.bsc1271963 | Schema changelog entry for the RBAC endpoint additions. |
| schema/spacewalk/common/data/namespace.sql | Seed systems.profiles namespace rows with descriptions (R/W). |
| schema/spacewalk/common/data/endpointNamespace.sql | Seed endpoint-to-namespace mappings so profile endpoints belong to systems.profiles (R/W). |
| schema/spacewalk/common/data/endpoint.sql | Seed missing CompareProfiles/CompareSystems endpoints. |
| java/webapp/src/main/webapp/WEB-INF/nav/system_detail.xml | Switch “Profiles” tab ACL to authorized_for(systems.profiles) for correct rendering. |
| java/spacewalk-java.changes.cbbayburt.bsc1271963 | Java changelog entry for the navigation fix. |
Comments suppressed due to low confidence (1)
schema/spacewalk/upgrade/susemanager-schema-5.2.9-to-susemanager-schema-5.2.10/100-rbac-package-profiles.sql:28
- Typo in the comment: the namespace used throughout this migration is
systems.profiles(plural), but this comment sayssystem.profiles(singular).
-- Move package profile related (modify) endpoints to 'system.profiles' namespace
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cbbayburt
force-pushed
the
bsc1271963
branch
3 times, most recently
from
July 27, 2026 13:29
585552b to
c125967
Compare
cbbayburt
marked this pull request as ready for review
July 27, 2026 14:18
cbbayburt
requested review from
mcalmer and
parlt91
and removed request for
a team
July 27, 2026 14:18
parlt91
approved these changes
Jul 28, 2026
parlt91
left a comment
Contributor
There was a problem hiding this comment.
Besides the failing changelog test it looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes RBAC mappings for the
systems.profilesnamespace:systems.profilesDocumentation
Test coverage
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/31292
Port: https://github.com/SUSE/spacewalk/pull/31392
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!