Skip to content

INTW26: Review end page and submission page#248

Closed
SaqAsh wants to merge 105 commits intomainfrom
INTW26-review-end-page-submission-page
Closed

INTW26: Review end page and submission page#248
SaqAsh wants to merge 105 commits intomainfrom
INTW26-review-end-page-submission-page

Conversation

@SaqAsh
Copy link
Collaborator

@SaqAsh SaqAsh commented Feb 11, 2026

Summary

  • Adds the review end page with scoring summary, final comments, and submission functionality
  • Implements review scoring pages (D2L, Skill, PFSG, Team Player) with rating components
  • Includes review dashboard with expandable rows, filtering, sorting, and search
  • Modernizes review components (PascalCase file naming, useContext, extracted private components)
  • Adds API clients for auth refresh and GraphQL request utilities

Test plan

  • Verify review flow works end-to-end: info -> scoring stages -> end/submission page
  • Confirm review data is correctly submitted to the backend
  • Test review dashboard filtering, sorting, and search functionality
  • Check responsive layout on mobile screen sizes

🤖 Generated with Claude Code

aaggarwal10 and others added 30 commits June 28, 2023 18:08
* fix login bug by removing onauthChange callback

* lint

* remove unused imports

---------

Co-authored-by: TW1234567 <117593511+TW1234567@users.noreply.github.com>
Co-authored-by: Thomas Wu <orangeleaves@v1040-wn-rt-b-24-91.campus-dynamic.uwaterloo.ca>
* Add review scoring pages

* Only allow 1 through 5 for review scores

* Fix linter issues

* Fix review comments
…eperating react from fetch calls (#151)

Co-authored-by: Thomas Wu <orangeleaves@Thomass-MacBook-Pro.local>
Co-authored-by: Thomas Wu <orangeleaves@v1040-wn-rt-a-46-41.campus-dynamic.uwaterloo.ca>
* Add question answer component and dummy data

* fix login bug by removing onauthChange callback (#148)

* fix login bug by removing onauthChange callback

* lint

* remove unused imports

---------

Co-authored-by: Thomas Wu <orangeleaves@v1040-wn-rt-b-24-91.campus-dynamic.uwaterloo.ca>

* Resolve package conflict to allow for MUIDataTable style (#149)

* Fix Team (#152)

* Changing Application Roles (#155)

* fix login bug by removing onauthChange callback (#148) (#150)

* fix login bug by removing onauthChange callback

* lint

* remove unused imports

---------

Co-authored-by: TW1234567 <117593511+TW1234567@users.noreply.github.com>
Co-authored-by: Thomas Wu <orangeleaves@v1040-wn-rt-b-24-91.campus-dynamic.uwaterloo.ca>

* add left content banner with people image

* Add blueprint images to left content panel

* Add report conflict modal

* fix report conflict modal style

* move modal as an optional button in the right titele

* add empty alt text for decorative images

---------

Co-authored-by: TW1234567 <117593511+TW1234567@users.noreply.github.com>
Co-authored-by: Thomas Wu <orangeleaves@v1040-wn-rt-b-24-91.campus-dynamic.uwaterloo.ca>
Co-authored-by: River Stanley <river.stanley@uwaterloo.ca>
Co-authored-by: Anish Aggarwal <anish.5@hotmail.com>
* rough

* implement and use ProtectedApplicaiton

* linting

* edit error handling for verfiying user

* revert secrets.ts change

---------

Co-authored-by: Thomas Wu <orangeleaves@Thomass-MacBook-Pro.local>
* updates application dashboard

* refactoring table styling

* updates dynamc applicant filtering, app count

* refactoring

* added table options

* removed toolbar

* readding toolbar lol

* fetching second choice status

* custom sorting function for name column

* adds for styling for second choice status

---------

Co-authored-by: aanxniee <caishajia@gmail.com>
* updates to make search, sorting, and filtering work

* moved application table query to queries.ts

* moved mui theme to utils

* refactoring get style functions + moved to utils

* fixed review rerouting issue

* removes mui comments and small updates

* runs lint and prettier

---------

Co-authored-by: aanxniee <caishajia@gmail.com>
* moves dashboard dropdown menu + updates styling

* fixes styling issues for status and second choice status
…185)

* 10/26/2023

* Co-authored-by: anushehatiff <anushehatiff@users.noreply.github.com>

* added heet's reviewInfoStage & type changes

---------

Co-authored-by: HeetShah <heetshah7642@gmail.com>
* creates query for secondchoicerole, new table tab

* added prop for whichChoiceTab

* fade out inactive tab

* clean up code

* remove space

* add types to type file, rename tabletitle, remove edit buttom temp.

* Update yarn.lock

* t

* tme

* l

* revert yarn.lock

* Update yarn.lock

* Update yarn.lock

* old yarn.lock
* adds conditional rendering based on selection on dropdown menu

* adds table columns for review table

* [INTF23] Second choice tab (#184)

* creates query for secondchoicerole, new table tab

* added prop for whichChoiceTab

* fade out inactive tab

* clean up code

* remove space

* add types to type file, rename tabletitle, remove edit buttom temp.

* Update yarn.lock

* t

* tme

* l

* revert yarn.lock

* Update yarn.lock

* Update yarn.lock

* old yarn.lock

* lints (#190)

* lints

* adds default value to dropdown menu

* adds conditional rendering based on selection on dropdown menu

* adds table columns for review table

* added second choice tabs to review table

* adds inner table to expandable row

* Revert "adds inner table to expandable row"

This reverts commit a801855.

---------

Co-authored-by: Jesse Li <53070256+Jess2772@users.noreply.github.com>
Co-authored-by: Heet Shah <58372785+HeetShah@users.noreply.github.com>
Co-authored-by: HeetShah <heetshah7642@gmail.com>
* update SKL page

update SKL page

* refactoring fetching application and render data

* linting

* loop through all role specific questions

---------

Co-authored-by: HeetShah <heetshah7642@gmail.com>
* review page - D2L

* modified scoring context listener

* fix score fetch

* change rubric score range

* updates rubrics

---------

Co-authored-by: HeetShah <heetshah7642@gmail.com>
* refactored pfsg and tp page

* modified scoring context position on TP and PFSG review pages

* removed old scoreboard on TP and PFSG page

* lints

* updates rubric

---------

Co-authored-by: HeetShah <heetshah7642@gmail.com>
Kriti Sodhi and others added 26 commits February 10, 2026 19:53
* feat: removed 2nd choice recc features

* removed 2nd recommend in MUI
* Remove package lock

* Add package-lock to gitignore

* Update yarn lock

* fix netfliy deploy errors

---------

Co-authored-by: mxc-maggiechen <mxc.maggiechen@gmail.com>
* add times applied column

* mapped to numerical values so that sorting works

* fixed timesApplied values
)

* started mobile fix

* hiding stepper on smaller screens

* disabled auth

* fix typo

* disable auth
* Finished most of styling

* Finished styling, added links to buttons

* Almost done styling, just need to make one small fix

* remove prototype landing page

---------

Co-authored-by: Lorena Rosati <lrosati@outlook.com>
Co-authored-by: mxc-maggiechen <mxc.maggiechen@gmail.com>
Co-authored-by: Maggie Chen <maggiechen@eduroam-campus-10-36-201-227.campus-dynamic.uwaterloo.ca>
* refactor types
* refactor raw queries
- Add ReviewProgressHeader component with step indicators
- Extract ReviewStage enum and constants to shared files
- Add rubric scoring criteria constants
- Add ReviewScores type definition
- Fix TypeScript implicit any types in reviewSkillStage
- Fix empty arrow functions in reviewStepper
- Add comments and skillsCategory fields to ApplicationDTO
- Improve review flow navigation and stepper logic

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update all import paths to match the new PascalCase filenames.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ew stages

The questions/answers data is derived from application props, not
independent state. Compute it directly during render instead of
syncing with useEffect.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace switch statements with Record lookups, use useContext instead of
Context.Consumer, hoist getStepState to module scope, and remove redundant
default export.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move pure functions and static data outside component, replace inner
functions with derived values, and use useContext instead of Consumer.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ponents, enforce ordering

- Replace legacy Context.Consumer render props with useContext hook across all rating stages
- Extract inline JSX into private components (ScoreSummary, EndForm, InfoBanner)
- Enforce private-components-above-export convention across all review files
- Remove unnecessary React fragments and fix self-closing tags
- Hoist static INFO_QUESTIONS array to module scope

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@netlify
Copy link

netlify bot commented Feb 11, 2026

Deploy Preview for uwblueprint failed.

Name Link
🔨 Latest commit 796861c
🔍 Latest deploy log https://app.netlify.com/projects/uwblueprint/deploys/698bdb8c49e94a00088db7d4

@SaqAsh SaqAsh closed this Feb 11, 2026
@SaqAsh SaqAsh deleted the INTW26-review-end-page-submission-page branch February 11, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.