fix: remove "[COPY]" from unarchived test + no draft archival#608
Open
fix: remove "[COPY]" from unarchived test + no draft archival#608
Conversation
|
Visit the preview URL for this PR (updated for commit 7a94a7e): https://jump-math-staging--pr608-julian-test-archivin-4mqs1ivm.web.app (expires Thu, 09 Nov 2023 03:36:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51 |
| {assessmentStatus === Status.PUBLISHED && ( | ||
| <> | ||
| <ArchiveButton assessmentId={assessmentId} /> | ||
| <Divider /> |
Collaborator
There was a problem hiding this comment.
why do we have both <Divider /> here and in line 24? Does it not work for nested?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Fix logic around test archiving
Implementation description
[NOTE: this has to get rebased on Joyce's PR before it will work properly.]
Two things:
Steps to test
What should reviewers focus on?
Checklist