Expose freezer sink max flush count and period#67
Open
SpeedyCoder wants to merge 2 commits intomasterfrom
Open
Expose freezer sink max flush count and period#67SpeedyCoder wants to merge 2 commits intomasterfrom
SpeedyCoder wants to merge 2 commits intomasterfrom
Conversation
… of timer to time flushing.
Contributor
|
This looks like it will:
Is this what we want? |
Contributor
Author
|
Ah yeah, I will fix the first bit. The second one is more of a question about what behaviour we want. With the old implementation if we kept writing 2 messages per second then it might end up flushing only after 8.5 minutes, so it might take this long to get an acknowledgement back. With this implementation the longest time to get an acknowledgement is 1 second by default or whatever you specify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives the user more control on how often the sink will flush.
Using ticker instead of timer makes the implementation simpler and makes sure messages gets flushed periodically.