Skip to content

refactor universal: drop obsolete and inconsistent memory_order parameters in RateCounter#1224

Open
ddvamp wants to merge 1 commit intouserver-framework:developfrom
ddvamp:userver-patch-rate_counter
Open

refactor universal: drop obsolete and inconsistent memory_order parameters in RateCounter#1224
ddvamp wants to merge 1 commit intouserver-framework:developfrom
ddvamp:userver-patch-rate_counter

Conversation

@ddvamp
Copy link
Copy Markdown
Contributor

@ddvamp ddvamp commented Apr 29, 2026

void Store(Rate desired, std::memory_order order = std::memory_order_relaxed) noexcept {

void Add(Rate arg, std::memory_order order = std::memory_order_relaxed) noexcept {

These parameters were added in this commit, and then turned out to be unnecessary in this one.

Since they are no longer in use and their presence contradicts the class description, they should be deleted.

@apolukhin
Copy link
Copy Markdown
Member

I do not think it is worth removing. We may need it one day

It is better to adjust the class description with with relaxed memory ordering by default

Copy link
Copy Markdown
Member

@apolukhin apolukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants