Skip to content

Enforce metadata_stradegy as extended#379

Open
bgruening wants to merge 5 commits intomasterfrom
metadata_stradegy
Open

Enforce metadata_stradegy as extended#379
bgruening wants to merge 5 commits intomasterfrom
metadata_stradegy

Conversation

@bgruening
Copy link
Copy Markdown
Member

set metadata_strategy to be 'extended' on a global level.

This will fix #369

The next step would be to clean the destination ... but this is optional.

@bgruening bgruening requested a review from gmauro May 5, 2022 14:54
@mira-miracoli
Copy link
Copy Markdown
Contributor

Can it be closed?

@bgruening
Copy link
Copy Markdown
Member Author

I think we should still do this. This should be the default and if needed we should opt-out.

@kysrpex kysrpex removed the request for review from gmauro July 19, 2023 14:22
@kysrpex kysrpex changed the title enforce metadata_stradegy as extended Enforce metadata_stradegy as extended Jul 19, 2023
@kysrpex
Copy link
Copy Markdown
Contributor

kysrpex commented Jul 19, 2023

At the moment, we are enforcing this through TPV in tool_defaults.yml. Since our only destinations on the job conf are local and tpv_dispatcher, I guess it makes sense to enable this on a global level.

What do you think?

@kysrpex
Copy link
Copy Markdown
Contributor

kysrpex commented Jul 19, 2023

Looking at destinations.yml.j2, Pulsar seems to require metadata_strategy: directory. Do we know if switching to a global setting would still keep the TPV override effective.

Again the TPV dry-run failure is normal and expected. The dry-run fails for the default tool because mock tools have no version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

set metadata_strategy on a global level

3 participants