Conversation
|
I wonder why this worked before? did we change the name of our favicon file? |
It worked before because our favicon was a patch in our fork. That patch was dropped https://github.com/usegalaxy-eu/issues/issues/919, then the icon was deployed as configuration by #1968 with the new name favicon_eu.ico, with the idea of not being in conflict with the icon provided in the source code. |
|
|
||
| location /favicon.ico { | ||
| alias {{ galaxy_server_dir }}/static/favicon.ico; | ||
| alias {{ galaxy_server_dir }}/static/favicon_eu.ico; |
There was a problem hiding this comment.
I propose #2001. It has the downside of asking the gunicorns for the favicon once every five days per-user, but the impact is minimal (most other static content is retrieved from the gunicorns at the moment). The upside is that favicon config is no longer managed in two different places.
The important bit is that it paves the way for https://github.com/usegalaxy-eu/issues/issues/927. A /static block can be added that uses the macro and adds a couple of caching headers for all static content).
3 participants
We need to remove this from nginx if we want Galaxy to serve it. The question is if we want this.