Fix bundler gem detection when using vendor/bundle - #435
Open
tamersp25 wants to merge 1 commit into
Open
Conversation
Add bundler/setup at script start so gems installed via 'bundle install' to vendor/bundle are properly detected by Gem::Specification.find_by_name(). This eliminates the need to run 'bundle exec ./whatweb'. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundler/setupat script start so gems installed viabundle installtovendor/bundleare properly detectedbundle exec ./whatwebafter installing dependenciesProblem
After running
bundle install, WhatWeb would still report missing gems becauseGem::Specification.find_by_name()only looks for system-wide gems, not those invendor/bundle.Test plan
bundle installto install gems tovendor/bundle./whatweb -h- should display help without "missing gems" error./whatweb --version- should display version info🤖 Generated with Claude Code