Add Manjaro Linux support for aarch64#81
Open
AlexTalker wants to merge 1 commit intouraimo:masterfrom
Open
Conversation
Add support for official Manjaro Linux Docker image ( https://github.com/manjaro/manjaro-docker )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for official Manjaro Linux Docker image ( https://github.com/manjaro/manjaro-docker )
Summary
Since PR #47 has gone stale, I decided to approach the issue myself.
After evaluation of approach presented in previous PR comment versus the official way via BuildX I saw specifying target platform inside the
Dockerfileas a proper solution in comparison to changing GitHub Actions of the official images to provide the image under new tags.This however generates a warning which is a small price to pay for otherwise functional image.
See my GitHub Action result for the example.
If needed, specifying
--platformfordocker buildanddocker runmight be wrapped in a separate PR as I see it,especially since I don't have full list of supported values for it.