Skip to content

fix(otelgorm): added optional db key to skip tracing#120

Open
WilliamDeKeyzer wants to merge 9 commits intouptrace:mainfrom
WilliamDeKeyzer:feature/no-trace-option
Open

fix(otelgorm): added optional db key to skip tracing#120
WilliamDeKeyzer wants to merge 9 commits intouptrace:mainfrom
WilliamDeKeyzer:feature/no-trace-option

Conversation

@WilliamDeKeyzer
Copy link
Copy Markdown

@WilliamDeKeyzer WilliamDeKeyzer commented Feb 28, 2024

Sometimes there are database operations ongoing that are continuously ongoing and are completely irrelevant for tracing UIs. You just don't want useless traces to be present in this case, as it generates a lot of noise.

With the custom key (which is exported from this lib) you can now set it in the relevant parts of your own codebase.
db.Set(otelgorm.EnabledTraceDatabaseKey, false)

This will make sure the next queries towards this db object will not start new traces.

Do not forget to un-set this db key is other clals happen on this db object and you do want to trace those.
db.Set(otelgorm.EnabledTraceDatabaseKey, true)

@WilliamDeKeyzer WilliamDeKeyzer changed the title added optional db key to skip tracing fix: added optional db key to skip tracing Feb 28, 2024
@WilliamDeKeyzer WilliamDeKeyzer changed the title fix: added optional db key to skip tracing fix(otelgorm): added optional db key to skip tracing Feb 28, 2024
Comment thread otelgorm/README.md Outdated
@xBlaz3kx
Copy link
Copy Markdown

xBlaz3kx commented Feb 11, 2025

Sometimes there are database operations ongoing that are continuously ongoing and are completely irrelevant for tracing UIs. You just don't want useless traces to be present in this case, as it generates a lot of noise.

With the custom key (which is exported from this lib) you can now set it in the relevant parts of your own codebase. db.Set(otelgorm.EnabledTraceDatabaseKey, false)

This will make sure the next queries towards this db object will not start new traces.

Do not forget to un-set this db key is other clals happen on this db object and you do want to trace those. db.Set(otelgorm.EnabledTraceDatabaseKey, true)

Hey @WilliamDeKeyzer,

one non-invasive workaround for your would be using an OpenTelemetry collector, where you could filter out the continuous traces, for example health checks/pings, etc. and they wont be visible in your UI/tracing backend. But that would still generate a lot of traffic between the service and collector, so if that matters in your use case, your proposed solution is fine.

@WilliamDeKeyzer
Copy link
Copy Markdown
Author

Would it be possible to merge this then? :)

@survivorbat
Copy link
Copy Markdown

@vmihailenco could you please have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants