fix(otelgorm): added optional db key to skip tracing#120
fix(otelgorm): added optional db key to skip tracing#120WilliamDeKeyzer wants to merge 9 commits intouptrace:mainfrom
Conversation
…Keyzer/opentelemetry-go-extra into feature/no-trace-option
Hey @WilliamDeKeyzer, one non-invasive workaround for your would be using an OpenTelemetry collector, where you could filter out the continuous traces, for example health checks/pings, etc. and they wont be visible in your UI/tracing backend. But that would still generate a lot of traffic between the service and collector, so if that matters in your use case, your proposed solution is fine. |
|
Would it be possible to merge this then? :) |
|
@vmihailenco could you please have a look? |
Sometimes there are database operations ongoing that are continuously ongoing and are completely irrelevant for tracing UIs. You just don't want useless traces to be present in this case, as it generates a lot of noise.
With the custom key (which is exported from this lib) you can now set it in the relevant parts of your own codebase.
db.Set(otelgorm.EnabledTraceDatabaseKey, false)This will make sure the next queries towards this db object will not start new traces.
Do not forget to un-set this db key is other clals happen on this db object and you do want to trace those.
db.Set(otelgorm.EnabledTraceDatabaseKey, true)