Skip to content

Rns integration - #255

Open
jonathansmirnoff wants to merge 2 commits into
unstoppabledomains:masterfrom
jonathansmirnoff:add-rsk-v2
Open

Rns integration#255
jonathansmirnoff wants to merge 2 commits into
unstoppabledomains:masterfrom
jonathansmirnoff:add-rsk-v2

Conversation

@jonathansmirnoff

Copy link
Copy Markdown

Background

In this PR we have done the RNS integration. For more information about it please go check https://dev.rootstock.io/rif/rns/.

Changes

It was created a new NamingService for Rns.

Code Review

This Pull Request was thoroughly reviewed and meets all Code Review Standards pertaining to:

  • Implementation - satisfied acceptance criteria
  • Communication - notified engineers/stakeholders about impactful changes
  • Error handling - handled, logged & alerted on errors
  • Documentation - wrote readable code & commits, documented unintuitive code
  • Testing - unit & E2E test coverage, tested in staging, DB migrations backwards compatible
  • Security - sanitized inputs, vetted dependencies, validated/secured API requests, no committed secrets
  • Performance - optimized expensive algorithms & database queries

Please select all applied standards relevant to this PR.

Confirmation

  • Assignee Confirmation - I (the author) have filled out the template above
  • Reviewer Confirmation - I (a/the reviewer) confirm 1) the author has filled out the template and checked the box that says Assignee Confirmation 2) I reviewed the code and selected all applicable items in the code review section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant