configure.ac: use AC_PROG_AR#4418
Open
lanodan wants to merge 1 commit into
Open
Conversation
Member
|
Many checks failed. |
Member
|
@lanodan You may want to use |
This way AR is properly queried for including when cross-compiling where a more graceful fallback than "ar" is needed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4418 +/- ##
=======================================
Coverage 85.98% 85.98%
=======================================
Files 255 255
Lines 63884 63885 +1
=======================================
+ Hits 54931 54932 +1
Misses 8953 8953 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I think this would be better: diff --git a/configure.ac b/configure.ac
index 1ed5359e0..29e45f992 100644
--- a/configure.ac
+++ b/configure.ac
@@ -265,9 +265,14 @@ AC_C_INLINE
# Typically, this is immediately after AC_PROG_CC, ...
gl_EARLY
+# AC_PROG_AR was introduced in autoconf-2.72
+# AM_PROG_AR was introduced in automake-1.12.0
+# https://lists.gnu.org/archive/html/automake/2012-05/msg00014.html
+m4_ifdef([AC_PROG_AR], [AC_PROG_AR], [m4_ifdef([AM_PROG_AR], [AM_PROG_AR])])
+AC_ARG_VAR([AR], [ar command or path])
AC_ARG_VAR(RANLIB,[ranlib command or path])
AC_PROG_RANLIB
-PRETTY_ARG_VAR([AR], [ar command or path], [ar])
+
AC_C_BIGENDIAN
if test "$cross_compiling" = "yes"; then
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way AR is properly queried for including when cross-compiling
where a more graceful fallback than "ar" is needed.