bindings/python: sync version with core via CMakeLists.txt#2301
Closed
Jvlegod wants to merge 1 commit intounicorn-engine:masterfrom
Closed
bindings/python: sync version with core via CMakeLists.txt#2301Jvlegod wants to merge 1 commit intounicorn-engine:masterfrom
Jvlegod wants to merge 1 commit intounicorn-engine:masterfrom
Conversation
Signed-off-by: Jvle <keke.oerv@isrc.iscas.ac.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello maintainers,
I encountered issues while compiling the Python RPM package for the distribution and attempting to compile it from source.
errors
from RPM compile
We should notice that
Error: The version in the Python package metadata 0.0.0 normalizes to zero.from Source compile
I use
setup.pyto compile atar.gzfile.I discovered that the Unicorn version was set to
0.0.0because the Python bindings did not determine their version during the package compilation process, unlike other language interfaces.my change
I have implemented a function in
setup.pyto automatically retrieve the version, which depends on the top-level CMakeLists.txt. I believe this is a reasonable approach because the version-related variables in CMake are highly stable; my observations show that this section of the CMake code hasn't changed significantly since version1.0.2-rc1. Additionally, I have included a fallback var using aDEFAULT_VERSIONvariable to specify the version if needed.:>