Skip to content

add ctl_get_invalid_addr#6

Merged
wtdcode merged 2 commits intounicorn-engine:mainfrom
PhilippTakacs:read_error
Feb 18, 2026
Merged

add ctl_get_invalid_addr#6
wtdcode merged 2 commits intounicorn-engine:mainfrom
PhilippTakacs:read_error

Conversation

@PhilippTakacs
Copy link
Copy Markdown
Contributor

@PhilippTakacs
Copy link
Copy Markdown
Contributor Author

@wtdcode
The feature is merged can you also merge the rust bindings?

@wtdcode
Copy link
Copy Markdown
Member

wtdcode commented Feb 17, 2026

CI is red =/.

@PhilippTakacs
Copy link
Copy Markdown
Contributor Author

When I understand this correct the problem is that the CI tries to build the unicorn-engine crate based on the latest unicorn-engine-sys crate of crates.io. This fails because ControlType::INVALID_ADDR is new in the unicorn-engine-sys crate.

I have no clue what is the best way to fix this.

@wtdcode
Copy link
Copy Markdown
Member

wtdcode commented Feb 17, 2026

When I understand this correct the problem is that the CI tries to build the unicorn-engine crate based on the latest unicorn-engine-sys crate of crates.io. This fails because ControlType::INVALID_ADDR is new in the unicorn-engine-sys crate.

I have no clue what is the best way to fix this.

Oh seems true. I need to figure out how to fix this.

Use --workspace to test publish all crates in the workspace. Now the
crates of the repo are used as dependency to test if the publish works.
@PhilippTakacs
Copy link
Copy Markdown
Contributor Author

using cargo publish --workspace should fix this kind of bugs. I believe the the --allow-dirty can also dropped. Might also be useful for the Publish job.

@wtdcode wtdcode merged commit f7d5b1b into unicorn-engine:main Feb 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants