Conversation
…manage household ID collisions for RDI imports
Implemented two new test cases to verify the behavior of the CreateLaxHouseholds endpoint when handling household ID collisions. The tests ensure that existing household IDs are registered correctly in extra_hh_rdis and that no new PendingHousehold records are created when collisions occur.
…ng and improve payload validation Updated the logic in the CreateLaxHouseholds class to enhance the management of household ID collisions and ensure valid payloads are processed correctly. The changes include consolidating error handling and adjusting the flow for adding extra household RDI IDs.
…h_findings_from_dedup_engine
…d RDIs Updated the logic in the CreateLaxHouseholds class to correctly reference the selected RDI when adding extra household RDIs. This change ensures that the appropriate RDI instance is used, improving the accuracy of household data management.
…specific fields Updated the _manage_collision method to handle household data collisions by excluding certain fields from being overwritten. This ensures that critical household information remains intact during updates. Additionally, removed unnecessary assertions from the test suite related to collision detection.
Master back
* Refactor API tests to pytest functions + new factories * test_tasks.py: refactor * test_upload: increasing coverage * Celery tasks coverage improvement
Ind add biometrics details
… reconciliation overdue recipients (#5850) * exclude staff * fix reconciliantion in include program, optimize
# Conflicts: # src/hope/apps/payment/services/payment_plan_services.py # tests/unit/api_contract/_api_checker/test_verification_records/_api_rest_business-areas_business-area-0_programs_8u0m_payment-verifications_ed72c97f-7f07-4a10-8b67-2c9ae8f67f34_verifications_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json # tests/unit/api_contract/_api_checker/test_verification_records/_api_rest_business-areas_business-area-0_programs_8u0m_payment-verifications_ed72c97f-7f07-4a10-8b67-2c9ae8f67f34_verifications_d7b0b4ff-7a96-47ca-a5e0-3aeb40b23c73_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json # tests/unit/api_contract/_api_checker/test_verification_records/_api_rest_business-areas_business-area-0_programs_cno6_payment-verifications_66fc7e08-d0ad-40aa-a165-346c09f70076_verifications_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json # tests/unit/api_contract/_api_checker/test_verification_records/_api_rest_business-areas_business-area-0_programs_cno6_payment-verifications_66fc7e08-d0ad-40aa-a165-346c09f70076_verifications_3463c79e-b9ac-441f-8f57-923a6b6596b0_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json # tests/unit/api_contract/_api_checker/test_verification_records/_api_rest_business-areas_business-area-0_programs_pc95_payment-verifications_f6fdb805-6ec5-476d-b72a-d0e8c13b0321_verifications_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json # tests/unit/api_contract/_api_checker/test_verification_records/_api_rest_business-areas_business-area-0_programs_pc95_payment-verifications_f6fdb805-6ec5-476d-b72a-d0e8c13b0321_verifications_b318df4f-09db-4e5e-ad03-e60fbf4e0da8_/get/dc937b59892604f5a86ac96936cd7ff09e25f18ae6b758e8014a24c7fa039e91.response.json # tests/unit/apps/payment/test_payment_plan_services.py
[AB#290132]-set up document type to empty in initial household filter
Targeting - Add option to list IDs that will pay alternative collector instead of Primary collector
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5856 +/- ##
==========================================
+ Coverage 91.10% 91.29% +0.18%
==========================================
Files 500 499 -1
Lines 34372 34373 +1
Branches 3549 3562 +13
==========================================
+ Hits 31316 31382 +66
+ Misses 2268 2214 -54
+ Partials 788 777 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@domdinicola @ntrncic How it is possible that we have +19,620 lines modified in this PR and 3 uncovered lines makes 96.80851% patch coverage? @domdinicola Do we want to keep it in “Ready for review” status and clutter the list? |
# Conflicts: # tests/unit/apps/payment/test_payment_plan_services.py
Master merge 07042026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.