Change 'countries' to be more accurate on Giga Maps#194
Open
reanbrenda wants to merge 2 commits intomainfrom
Open
Change 'countries' to be more accurate on Giga Maps#194reanbrenda wants to merge 2 commits intomainfrom
reanbrenda wants to merge 2 commits intomainfrom
Conversation
reanbrenda
force-pushed
the
fix/worldwide-and-explore-copy
branch
from
19090c6 to
1cfd75e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated worldwide header copy from Worldwide 219 Countries style to 219 countries and territories.
Implemented by changing the global breadcrumb component to render one combined i18n string.
Updated only the Locations mapped subtext:
from across 219 countries
to across 219 countries and territories
and left other across {{count}} countries uses unchanged.
Updated CTA copy:
Explore countries -> Explore (English locale).
Added i18n keys to support these changes:
countries-and-territories
across-no-countries-and-territories
in en, es, and pt resources (with localized text).
Related Issue
Proposed Changes
click up link-https://app.clickup.com/t/25789471/TECH-9470
Screenshots (if applicable)
before
after
Checklist
Additional Notes