Conversation
The "files" allowlist in package.json already governs the tarball, and .npmignore referenced paths that no longer exist (tests/, example.ts).
sideEffects: false lets bundlers tree-shake. Importing hyperaxe only defines factories; there are no import-time side effects.
Switch prepare to prepublishOnly so the build runs ahead of npm publish rather than on every install. Since prepublishOnly (unlike prepare) does not run on npm pack, have test-pack.sh build first so it still packs a fresh dist, matching what publish does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small packaging and repo cleanups: drop a dead ignore file, tidy
.gitignore, mark the package side-effect free, and build at publish time instead of on every install.Changes
.npmignore. Thefilesallowlist already governs the tarball, and the file referenced paths that no longer exist (tests/,example.ts)..gitignore: addcoverageand*.log.sideEffects: falseso bundlers can tree-shake; importing hyperaxe has no import-time side effects.preparetoprepublishOnlyso the build runs ahead of publish, not on every install. SinceprepublishOnlydoes not run onnpm pack,test-pack.shnow builds first so it still packs a freshdist.Verification
npm test,npm run coverage(100%), andnpm run test:pack(from a clean tree) pass locally.