refactor: use UeberauthOidcc as a library#105
Open
paulswartz wants to merge 2 commits intoueberauth:masterfrom
Open
refactor: use UeberauthOidcc as a library#105paulswartz wants to merge 2 commits intoueberauth:masterfrom
UeberauthOidcc as a library#105paulswartz wants to merge 2 commits intoueberauth:masterfrom
Conversation
paulswartz
force-pushed
the
refactor-oidcc
branch
2 times, most recently
from
6d2b9c4 to
d092ef3
Compare
paulswartz
force-pushed
the
refactor-oidcc
branch
from
d092ef3 to
a2bf877
Compare
Member
|
I love it! I would love to hear @doomspork thoughts as well! |
Contributor
|
@yordis What steps do we think we could take here to get this merged? Do we need an app POC? Are there follow up steps here? Or is this good to merge as is? |
yordis
reviewed
Apr 28, 2025
Member
|
@snewcomer overall it seems good, but I would prefer to do a smoke test, I am not using this provider at the moment, are you able to help me here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yordis not 💯 sure this is what you meant in erlef/oidcc#263, but I gave it a shot anyways.
Other than requiring users to update to Erlang 26 and possibly changing some error messages, this should be backwards compatible with existing
Ueberauth.Strategy.Googleconfigurations.Benefits:
Cons: