[achievements] tests for recent_achievements on the UI frontend side#1496
Open
bensim0305 wants to merge 15 commits intodevfrom
Open
[achievements] tests for recent_achievements on the UI frontend side#1496bensim0305 wants to merge 15 commits intodevfrom
bensim0305 wants to merge 15 commits intodevfrom
Conversation
…n shows on the frontend UI view
Contributor
|
The test worked out great! I just have a minor question regarding the recent achievements not being called. |
Contributor
Author
|
It looked like the |
jiayuew1
approved these changes
May 24, 2025
Contributor
jiayuew1
left a comment
There was a problem hiding this comment.
Thank you for the explanation !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures coverage of PR #1257 . This PR also caught a bug where the "recent_achievements" function was not being called even on the user's own profile, so made the small fix in the user_achievements view to include the recent achievements. This test covers that the user achievement attributes are populating correctly on the frontend.