Skip to content

[P2P] fixing nixlbench #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YangZhou1997 merged 2 commits into from
Mar 20, 2026
Merged

[P2P] fixing nixlbench #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff26ede
[P2P] fixing nixlbench
YangZhou1997 Mar 20, 2026
c2ba900
nits
YangZhou1997 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/nixlbench_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ MINICONDA_DIR="${HOME}/nfs/miniconda3"
CONDA_ENV="uccl-ci-sandbox"

NIXL_SRC_DIR="/tmp/nixl_ci_$$"
ABSEIL_DIR="/tmp/abseil_ci_$$"
NIXL_REPO="https://github.com/ai-dynamo/nixl.git"
ABSEIL_TAG="20240116.2"

ARCH=$(uname -m)
[ "${ARCH}" = "arm64" ] && ARCH="aarch64"
Expand All @@ -32,7 +34,7 @@ cleanup() {
kill "${ETCD_PID}" 2>/dev/null || true
wait "${ETCD_PID}" 2>/dev/null || true
fi
rm -rf "${NIXL_SRC_DIR}"
rm -rf "${NIXL_SRC_DIR}" "${ABSEIL_DIR}"
}
trap cleanup EXIT

Expand All @@ -50,6 +52,23 @@ make install PYTHON=python3 LIBDIR="${NIXL_INSTALL_DIR}/lib" PREFIX="${NIXL_INST

export LIBRARY_PATH="${NIXL_INSTALL_DIR}/lib:${LIBRARY_PATH:-}"

# ── Build and install Abseil (NIXL needs absl_log; Ubuntu 24.04's Abseil is too old) ─
echo "=== Building Abseil (required by NIXL) ==="
git clone --depth 1 --branch "${ABSEIL_TAG}" https://github.com/abseil/abseil-cpp.git "${ABSEIL_DIR}"
cd "${ABSEIL_DIR}"
mkdir build && cd build
cmake .. \
-DCMAKE_INSTALL_PREFIX="${NIXL_INSTALL_DIR}" \
-DCMAKE_POSITION_INDEPENDENT_CODE=ON \
-DABSL_BUILD_TESTING=OFF \
-DABSL_ENABLE_INSTALL=ON
cmake --build . -j"$(nproc)"
cmake --install .
cd "${UCCL_ROOT}"

# Prefer our Abseil over system (Ubuntu's lacks absl_log)
export PKG_CONFIG_PATH="${NIXL_INSTALL_DIR}/lib/pkgconfig:${NIXL_INSTALL_DIR}/lib/${ARCH}-linux-gnu/pkgconfig:${PKG_CONFIG_PATH:-}"

# ── Clone NIXL ────────────────────────────────────────────────────────────────
echo "=== Cloning latest NIXL ==="
git clone --depth 1 "${NIXL_REPO}" "${NIXL_SRC_DIR}"
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/uccl-build-test-amd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ jobs:
if: >
github.event_name == 'push' ||
(github.event_name == 'pull_request' &&
!github.event.pull_request.head.repo.fork &&
github.event.pull_request.draft == false &&
contains(github.event.pull_request.labels.*.name, 'run-benchmark'))
runs-on: ubuntu-latest
permissions:
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/uccl-build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ jobs:
if: >
github.event_name == 'push' ||
(github.event_name == 'pull_request' &&
!github.event.pull_request.head.repo.fork &&
github.event.pull_request.draft == false)
contains(github.event.pull_request.labels.*.name, 'run-benchmark'))
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down Expand Up @@ -100,8 +99,6 @@ jobs:
if: >
github.event_name == 'push' ||
(github.event_name == 'pull_request' &&
!github.event.pull_request.head.repo.fork &&
github.event.pull_request.draft == false &&
contains(github.event.pull_request.labels.*.name, 'run-benchmark'))
runs-on: ubuntu-latest
permissions:
Expand Down
Loading