test(origin): add benchmark for number of http connections#622
Draft
sambhav-jain-16 wants to merge 1 commit into
Draft
test(origin): add benchmark for number of http connections#622sambhav-jain-16 wants to merge 1 commit into
sambhav-jain-16 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Go benchmark in origin/blobclient to quantify how many TCP connections are established per TransferBlob call (server-side Accept() count), comparing HTTP vs HTTPS behavior to surface keep-alive/connection reuse differences.
Changes:
- Added a benchmark harness for
TransferBlobthat uploads a fixed-size blob against a localhttptestserver. - Introduced a
net.Listenerwrapper to count accepted TCP connections and reportconns/opas a benchmark metric.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b537e8c to
6d6d3f7
Compare
6d6d3f7 to
d9f2b38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.