Make cellsToLinkedMultiPolygon tests order independent#1133
Merged
ajfriend merged 5 commits intouber:masterfrom Mar 5, 2026
Merged
Make cellsToLinkedMultiPolygon tests order independent#1133ajfriend merged 5 commits intouber:masterfrom
cellsToLinkedMultiPolygon tests order independent#1133ajfriend merged 5 commits intouber:masterfrom
Conversation
Collaborator
Author
|
Note: the CLI tests in I think just making that change with the migration is easier than trying to generalize the CLI tests. cc: @dfellis |
isaacbrodsky
approved these changes
Mar 3, 2026
justinhwang
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prepare for #1127, this PR updates the
cellsToLinkedMultiPolygontests to not depend on a specific polygon order, since thecellsToMultiPolygonbackend will return a different order.Those tests should now pass before and after the migration. Also, added a test containing cells that fail for the current algo, but should pass with the new one.