Skip to content

Make cellsToLinkedMultiPolygon tests order independent#1133

Merged
ajfriend merged 5 commits intouber:masterfrom
ajfriend:aj/poly_tests
Mar 5, 2026
Merged

Make cellsToLinkedMultiPolygon tests order independent#1133
ajfriend merged 5 commits intouber:masterfrom
ajfriend:aj/poly_tests

Conversation

@ajfriend
Copy link
Collaborator

@ajfriend ajfriend commented Mar 2, 2026

To prepare for #1127, this PR updates the cellsToLinkedMultiPolygon tests to not depend on a specific polygon order, since the cellsToMultiPolygon backend will return a different order.

Those tests should now pass before and after the migration. Also, added a test containing cells that fail for the current algo, but should pass with the new one.

@coveralls
Copy link

coveralls commented Mar 2, 2026

Coverage Status

coverage: 99.095%. remained the same
when pulling 9ebad97 on ajfriend:aj/poly_tests
into 8ac991e on uber:master.

@ajfriend
Copy link
Collaborator Author

ajfriend commented Mar 2, 2026

Note: the CLI tests in tests/cli/cellsToMultiPolygon.txt still hardcode exact vertex order. The migration will change the starting vertex within each loop (a cyclic rotation), so the expected outputs will need to be regenerated. (But when viewing the diff, large chunks should remain unchanged.)

I think just making that change with the migration is easier than trying to generalize the CLI tests. cc: @dfellis

@ajfriend ajfriend merged commit 1d5346b into uber:master Mar 5, 2026
47 checks passed
@ajfriend ajfriend deleted the aj/poly_tests branch March 5, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants