WIP: Refactoring & Fix issue on nvim#101
Conversation
It fixes "neovim's system does not support background..." issue
Web.HTTP still require Process module
|
I'll fix tests later. Btw, the behavior was tested only in macOS Sierra so it should be tested in other platform as well. |
| return 0 | ||
| endfunction "}}} | ||
|
|
||
| function! openbrowser#__system__(...) |
There was a problem hiding this comment.
Instead of removing this function, please use s:Process.execute() in this function.
It should also pass failed tests.
|
@lambdalisue Does this PR fix #102 too? |
|
ping |
|
Yes but to support neovim correctly, it should use |
|
@lambdalisue hm, like this? (I don't know if -let s:Process = vital#openbrowser#import('System.Process')
+let s:Process = vital#openbrowser#import('System.Process.Job') |
|
We have to wait vim-jp/vital.vim#513 |
|
@lambdalisue Okay. I made a workaround about this in #104. |
So would you want to wait |
|
Yes. |
|
Ok! |
#98 (comment)
vim-jp/vital.vim#533