Skip to content

Optimize Parallel instance in GenSpawnInstances to avoid allocation. #4599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmichael44 wants to merge 1 commit into
base: series/3.x
Choose a base branch
from
+15 −9
Open

Optimize Parallel instance in GenSpawnInstances to avoid allocation. #4599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions kernel/shared/src/main/scala/cats/effect/kernel/instances/GenSpawnInstances.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

package cats.effect.kernel.instances

import cats.{~>, Align, Applicative, CommutativeApplicative, Functor, Monad, Parallel}
import cats.{~>, Align, Applicative, CommutativeApplicative, Functor, Id, Monad, Parallel}
import cats.data.Ior
import cats.effect.kernel.{GenSpawn, ParallelF}
import cats.implicits._
Expand All @@ -32,15 +32,9 @@ trait GenSpawnInstances {

def monad: Monad[M] = M

def sequential: F ~> M =
new (F ~> M) {
def apply[A](fa: F[A]): M[A] = ParallelF.value[M, A](fa)
}
def sequential: F ~> M = GenSpawnInstances.cachedSequential.asInstanceOf[F ~> M]

def parallel: M ~> F =
new (M ~> F) {
def apply[A](ma: M[A]): F[A] = ParallelF[M, A](ma)
}
def parallel: M ~> F = GenSpawnInstances.cachedParallel.asInstanceOf[M ~> F]
}

implicit def commutativeApplicativeForParallelF[F[_], E](
Expand Down Expand Up @@ -91,3 +85,15 @@ trait GenSpawnInstances {

}
}

private object GenSpawnInstances {
private val cachedSequential: ParallelF[Id, *] ~> Id =
new (ParallelF[Id, *] ~> Id) {
def apply[A](fa: ParallelF[Id, A]): Id[A] = ParallelF.value[Id, A](fa)
}

private val cachedParallel: Id ~> ParallelF[Id, *] =
new (Id ~> ParallelF[Id, *]) {
def apply[A](ma: Id[A]): ParallelF[Id, A] = ParallelF[Id, A](ma)
}
}
Loading