Feat 17408 : Add remove option for object permissions rule

[LTan-101104]

This PR aims to fix: #17408

Main modification includes adding a new column for dropdown in the object permission rule table (containing options for editing and removal). Removal logic is implemented using existing pattern with hook useResetObjectPermission (relies on existing hooks useUpsertFieldPermissionInDraftRole and useUpsertObjectPermissionInDraftRole).

Feel free to suggest any necessary changes. Functionality (unrestricted access is allowed when permission removal is applied) is already tested.

Demo video: https://drive.google.com/file/d/1M4RYHw-JEhDdJksKkL3MY_VyXAV3aS9I/view?usp=sharing

[github-actions]

	Fails
🚫	node failed.

Log

Details

�[31mError: �[39m SyntaxError: Unexpected token 'C', "Contributo"... is not valid JSON
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:4259:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:6882:27)�[39m
�[90m    at readAllBytes (node:internal/deps/undici/undici:5807:13)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:103:5)�[39m
danger-results://tmp/danger-results-025a9803.json

Generated by 🚫 dangerJS against 3d83652

[cubic-dev-ai]

No issues found across 6 files

[greptile-apps]

Greptile Overview

Greptile Summary

This PR adds a removal option for object permission rules in the settings UI, enabling users to reset permissions back to unrestricted access.

Key Changes:

• Added a new options dropdown component (SettingsRolePermissionsObjectLevelTableRowOptionsDropdown) with "Remove rule" and "Edit" menu items
• Implemented useResetObjectPermission hook that sets all object and field permissions to null (unrestricted access)
• Updated table grid layout to accommodate the new options column
• The remove functionality correctly resets both object-level permissions (canReadObjectRecords, canUpdateObjectRecords, canSoftDeleteObjectRecords, canDestroyObjectRecords) and all associated field-level permissions

Issues Found:

• Debug/TODO comments were left in SettingsRolePermissionsObjectLevelObjectFieldPermissionTableRow.tsx that should be removed before merging
• Minor code style issues with comment formatting
• The dropdown follows the existing pattern from AdvancedFilterRecordFilterOptionsDropdown, maintaining consistency with the codebase

Confidence Score: 4/5

• Safe to merge after removing debug comments - no functional issues found
• The implementation follows existing patterns correctly and the logic is sound. Score is 4/5 only because of the debug/TODO comments that need cleanup before merging
• Clean up comments in SettingsRolePermissionsObjectLevelObjectFieldPermissionTableRow.tsx before merging

Important Files Changed

Filename	Overview
packages/twenty-front/src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelTableRowOptionsDropdown.tsx	New dropdown component for remove/edit actions - has style issues with unnecessary comments
packages/twenty-front/src/modules/settings/roles/role-permissions/object-level-permissions/field-permissions/components/SettingsRolePermissionsObjectLevelObjectFieldPermissionTableRow.tsx	Added debug/TODO comments that should be removed - no functional changes
packages/twenty-front/src/modules/settings/roles/role-permissions/object-level-permissions/hooks/useResetObjectPermission.ts	New hook implementing permission reset logic - follows existing patterns correctly

Sequence Diagram

sequenceDiagram
    participant User
    participant Dropdown as SettingsRolePermissionsObjectLevelTableRowOptionsDropdown
    participant Hook as useResetObjectPermission
    participant UpsertObjHook as useUpsertObjectPermissionInDraftRole
    participant UpsertFieldHook as useUpsertFieldPermissionInDraftRole
    participant RecoilState as settingsDraftRoleFamilyState

    User->>Dropdown: Click "..." options button
    Dropdown->>User: Show dropdown menu
    User->>Dropdown: Click "Remove rule"
    Dropdown->>Hook: resetObjectPermission(objectMetadataId)
    
    Hook->>RecoilState: Read current draft role state
    RecoilState-->>Hook: Return fieldPermissions & objectPermissions
    
    Hook->>Hook: Filter field permissions for object
    Hook->>Hook: Find existing object permission
    Hook->>Hook: Create reset permissions (all null)
    
    alt No existing object permission
        Hook->>UpsertObjHook: upsertObjectPermissionInDraftRole(newObjectPermission)
        UpsertObjHook->>RecoilState: Update with new object permission
    else Existing object permission
        Hook->>UpsertObjHook: upsertObjectPermissionInDraftRole(updatedObjectPermission)
        UpsertObjHook->>RecoilState: Update existing object permission
    end
    
    loop For each field permission
        Hook->>UpsertFieldHook: upsertFieldPermissionInDraftRole(resetFieldPermission)
        UpsertFieldHook->>RecoilState: Update field permission to null
    end
    
    RecoilState-->>User: UI updates to show unrestricted access

Loading

[greptile-apps]

_{3 files reviewed, 5 comments}

_{Edit Code Review Agent Settings | Greptile}

[Copilot]

Pull request overview

This pull request adds the ability to remove object permission rules from roles, addressing a gap where users could add permission rules but not delete them. The implementation follows existing patterns in the codebase by creating a dropdown menu with "Remove rule" and "Edit" options, similar to the AdvancedFilterRecordFilterOptionsDropdown.

Changes:

• Adds useResetObjectPermission hook to reset object and field permissions to null values
• Implements SettingsRolePermissionsObjectLevelTableRowOptionsDropdown component with remove and edit functionality
• Adjusts table grid layout to accommodate the new options dropdown column

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
useResetObjectPermission.ts	New hook that resets object and field permissions for a given object by setting all permission flags to null
SettingsRolePermissionsObjectLevelTableRowOptionsDropdown.tsx	New dropdown component providing remove and edit options for object permission rows
SettingsRolePermissionsObjectLevelTableRow.tsx	Integrates the new options dropdown into the permission table row
SettingsRolePermissionsObjectLevelTableHeader.tsx	Adds empty header cell for the new options column
ObjectLevelPermissionTableGridAutoColumns.ts	Adjusts grid column widths to accommodate the new options column
SettingsRolePermissionsObjectLevelObjectFieldPermissionTableRow.tsx	Adds documentation comments explaining permission handling behavior

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The hook parameter structure is inconsistent with the similar hook useUpsertObjectPermission. While useUpsertObjectPermission uses destructured object parameters ({ roleId }: { roleId: string }), this hook uses a direct parameter (roleId: string). For consistency with the codebase, consider updating to use the same parameter pattern as useUpsertObjectPermission.

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:24913

This environment will automatically shut down when the PR is closed or after 5 hours.

[LTan-101104]

@Bonapara Ready for review.

[etiennejouan]

Hi @LTan-101104 it works well ! Thanks and Congrats for your first contribution on Twenty repo 👏

I left small comments regarding design. Do not hesitate to reach me if not clear.

[etiennejouan]

Nitpick : Could you invert "Remove rule" and "Edit" to fit with design ? #17408 (comment)

[LTan-101104]

Moved Edit above Remove.

[etiennejouan]

To remove cf design

[LTan-101104]

Removed the cf

[LTan-101104]

@etiennejouan Hi, sorry for the late reply. I just made 2 fixes following your comment to make sure it appears similar to mentioned design

Please feel free to let me know if there is anything else I need to implement.

Thank you,

[etiennejouan]

Hi @LTan-101104 Thanks for your nice contribution 👍

[twenty-eng-sync]

Hey @etiennejouan! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

[twenty-eng-sync]

Hey @etiennejouan! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!