Messages Message Folder Association

[neo773]

This PR adds Message folder association for message channel messages,
Currently under testing phase, not ready yet.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR implements many-to-many relationship between message channel message associations and message folders using a junction table (messageChannelMessageAssociationMessageFolder). Messages can now belong to multiple folders, which is essential for email providers like Gmail where messages can have multiple labels.

Key Changes:

• Created new junction table entity with proper CASCADE delete actions and composite key uniqueness
• Added messageFolderExternalIds parsing in all three drivers (Gmail, IMAP, Microsoft)
• Implemented mapping from external folder IDs to internal database IDs before saving
• Updated folder deletion service to query via junction table
• Added comprehensive test coverage for new functionality
• Properly integrated within existing transaction boundaries

Architecture:

• Driver layer populates messageFolderExternalIds from provider-specific data (Gmail labelIds, IMAP folder paths, Microsoft parentFolderId)
• Import service maps external IDs to internal IDs using loaded message channel folders
• Save service creates folder associations within the same transaction as message creation
• Junction table prevents duplicates using composite key checks before insertion

Issues Found:

• One potential silent failure in empty string fallback (commented)

Confidence Score: 4/5

• This PR is relatively safe to merge with minor improvements needed
• The implementation follows proper patterns with junction tables, transaction boundaries, and duplicate prevention. Tests are updated appropriately. However, marked as testing phase by author, and one potential issue with empty string fallback exists. The architecture is sound but needs validation in production-like scenarios.
• Pay attention to messaging-save-messages-and-enqueue-contact-creation.service.ts for the empty string fallback issue on line 135

Important Files Changed

Filename	Overview
packages/twenty-server/src/modules/messaging/common/standard-objects/message-channel-message-association-message-folder.workspace-entity.ts	New junction table entity for many-to-many relationship between message associations and folders
packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-message-folder-association.service.ts	Handles saving message-folder associations with duplicate prevention using composite keys
packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-save-messages-and-enqueue-contact-creation.service.ts	Updated to map external folder IDs to internal IDs and save folder associations within transaction
packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts	Maps external folder IDs from message channel to internal IDs before saving messages
packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-delete-folder-messages.service.ts	Updated to use junction table to find messages associated with a folder for deletion
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-message-channel-message-association-message-folder-standard-flat-field-metadata.util.ts	Defines metadata for junction table with CASCADE delete actions and MANY_TO_ONE relations

Sequence Diagram

sequenceDiagram
    participant Driver as Message Driver<br/>(Gmail/IMAP/Microsoft)
    participant Import as MessagingMessagesImportService
    participant Save as SaveMessagesAndEnqueue<br/>ContactCreationService
    participant MsgSvc as MessagingMessageService
    participant FolderSvc as MessagingMessage<br/>FolderAssociationService
    participant DB as Database

    Driver->>Driver: Parse message with folder info
    Note over Driver: Gmail: labelIds<br/>IMAP: folderPath:uidValidity<br/>Microsoft: parentFolderId
    Driver->>Import: Return messages with<br/>messageFolderExternalIds
    
    Import->>Import: Load messageFolders from channel
    Import->>Import: Map external folder IDs<br/>to internal IDs
    Note over Import: folderExternalToInternalMap
    Import->>Import: Populate messageFolderIds<br/>on each message
    
    Import->>Save: saveMessagesAndEnqueueContactCreation(messages)
    
    Save->>DB: Start transaction
    
    Save->>MsgSvc: saveMessagesWithinTransaction()
    MsgSvc->>DB: Check existing messages/threads
    MsgSvc->>DB: Insert new threads
    MsgSvc->>DB: Insert new messages
    MsgSvc->>DB: Insert messageChannelMessageAssociations
    MsgSvc-->>Save: Return messageExternalIdTo<br/>MessageChannelMessageAssociationIdMap
    
    Save->>Save: Build folderAssociations array
    Note over Save: Filter messages with folder IDs<br/>Map to association IDs<br/>Filter empty associations
    
    Save->>FolderSvc: saveMessageFolderAssociations()
    FolderSvc->>DB: Check existing associations
    FolderSvc->>DB: Insert new folder associations<br/>(deduped by composite key)
    FolderSvc-->>Save: Complete
    
    Save->>DB: Commit transaction
    Save-->>Import: Complete

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

fallback to empty string could cause silent failures

The ?? fallback to empty string on line 135 could result in associations with empty IDs being created. Consider filtering before the map instead of after.

Suggested change

	messageExternalIdToMessageChannelMessageAssociationIdMap.get(
	message.externalId,
	) ?? '',
	.map((message) => {
	const associationId = messageExternalIdToMessageChannelMessageAssociationIdMap.get(
	message.externalId,
	);
	return associationId ? {
	messageChannelMessageAssociationId: associationId,
	messageFolderIds: message.messageFolderIds ?? [],
	} : null;
	})
	.filter(isDefined);

Prompt To Fix With AI

This is a comment left during a code review.
Path: packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-save-messages-and-enqueue-contact-creation.service.ts
Line: 134:136

Comment:
fallback to empty string could cause silent failures

The `??` fallback to empty string on line 135 could result in associations with empty IDs being created. Consider filtering before the map instead of after.

```suggestion
                  .map((message) => {
                    const associationId = messageExternalIdToMessageChannelMessageAssociationIdMap.get(
                      message.externalId,
                    );
                    return associationId ? {
                      messageChannelMessageAssociationId: associationId,
                      messageFolderIds: message.messageFolderIds ?? [],
                    } : null;
                  })
                  .filter(isDefined);
```

How can I resolve this? If you propose a fix, please make it concise.

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:15195

This environment will automatically shut down when the PR is closed or after 5 hours.

[charlesBochet]

upgrade 1-19 now

[github-actions]

Thanks @neo773 for your contribution!
This marks your 116th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

[twenty-eng-sync]

Hey @neo773! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

[prastoin]

Hey there
We should not run this command in production
It's going to synchronize all the workspace's twenty standard app which will make chocapic when run. As discussed this mise a niveau should be explicitly done at some point but not in this context ( even only if at field and object lvl )
We should use a comitted workspace migration see example

https://github.com/twentyhq/twenty/blob/a5180bf4747d1f51189520583a9c45490c9ead3b/packages/twenty-server/src/database/commands/upgrade-version-command/workspace-migrations/1771420702241-add-missing-system-fields-to-standard-objects.ts