fix: ALTER COLUMN from NUMERIC to TEXT causes corruption from SQLite's POV#5377
Draft
jussisaurio wants to merge 1 commit intomainfrom
Draft
fix: ALTER COLUMN from NUMERIC to TEXT causes corruption from SQLite's POV#5377jussisaurio wants to merge 1 commit intomainfrom
jussisaurio wants to merge 1 commit intomainfrom
Conversation
jussisaurio
commented
Feb 17, 2026
…s POV #3706 When ALTER TABLE ALTER COLUMN changes a column's type affinity (e.g. NUMERIC to TEXT), rewrite existing table data so stored values conform to the new affinity. Previously only the schema metadata was updated, leaving numeric values in a column now declared as TEXT. SQLite's integrity_check would then report corruption. The fix uses existing UPDATE translation paths to update all rows in the table so that the column uses the new affinity in both the table and all indexes. Closes #3706 Co-Authored-By: Claude Opus 4.6 <[email protected]>
78e2930 to
00f7b47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ALTER TABLE ALTER COLUMN changes a column's type affinity (e.g. NUMERIC to TEXT), rewrite existing table data so stored values conform to the new affinity. Previously only the schema metadata was updated, leaving numeric values in a column now declared as TEXT. SQLite's integrity_check would then report corruption.
The fix uses existing UPDATE translation paths to update all rows in the
table so that the column uses the new affinity in both the table and all
indexes.
Closes #3706