Skip to content

Conversation

@KillerxDBr
Copy link
Contributor

Fix incorrect flags when compiling nob.c with MSVC Clang

Expected:

ℹ️ [INFO] CMD: clang -Wall -Wextra -Wswitch-enum -std=c99 -g -D_CRT_SECURE_NO_WARNINGS -I. -o build/tests/minimal_log_level tests/minimal_log_level.c

Actual:

ℹ️ [INFO] CMD: clang /W4 /nologo /D_CRT_SECURE_NO_WARNINGS -I. -o build/tests/minimal_log_level tests/minimal_log_level.c
clang: error: no such file or directory: '/W4'
clang: error: no such file or directory: '/nologo'
clang: error: no such file or directory: '/D_CRT_SECURE_NO_WARNINGS'
🚨 [ERROR] command exited with exit code 1
🚨 [ERROR] command exited with exit code 1

Those flags would work in clang-cl, but i didnt found a way to differentiate those two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant