Skip to content

no fork now#41

Merged
trtshen merged 2 commits intomasterfrom
copilot/fix-38
Jul 2, 2025
Merged

no fork now#41
trtshen merged 2 commits intomasterfrom
copilot/fix-38

Conversation

@trtshen
Copy link
Copy Markdown
Owner

@trtshen trtshen commented Jul 2, 2025

No description provided.

@trtshen trtshen requested a review from Copilot July 2, 2025 16:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the test coverage workflow to generate the coverage report via a bash step, then share it as a single output used by the GitHub Script action. It also adds a separate log-only step for forked PRs.

  • Replace the old JS-based parsing with a Format coverage report bash step that computes metrics and exposes them via GITHUB_OUTPUT.
  • Update the actions/github-script step to consume the generated output instead of reading the file directly.
  • Introduce a fork-safe step that prints the report to logs instead of commenting.
Comments suppressed due to low confidence (3)

.github/workflows/test-coverage.yml:87

  • Ensure env: is indented at the same level as with: and uses: in the step, not nested under with, so the environment variable is recognized correctly by GitHub Actions.
      env:

.github/workflows/test-coverage.yml:60

  • [nitpick] Remove leading spaces before the table rows in the echoed report so that GitHub Markdown renders the coverage table correctly rather than as a code block.
          | Metric | Coverage |

.github/workflows/test-coverage.yml:80

  • [nitpick] The fallback string is a double-quoted literal and won’t preserve multi-line formatting if ever used; consider using a JS template literal (backticks) or rely solely on process.env.coverage_report.
          const comment = process.env.coverage_report || "${{ steps.coverage_report.outputs.coverage_report }}";

@trtshen trtshen merged commit e9b9bef into master Jul 2, 2025
@trtshen trtshen deleted the copilot/fix-38 branch July 2, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants