Add OrientedBoundingBox for spatial region analysis and particle selection - #929
Open
LasNikas wants to merge 24 commits into
Open
Add OrientedBoundingBox for spatial region analysis and particle selection#929LasNikas wants to merge 24 commits into
OrientedBoundingBox for spatial region analysis and particle selection#929LasNikas wants to merge 24 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
==========================================
- Coverage 89.58% 89.48% -0.10%
==========================================
Files 120 120
Lines 8628 8720 +92
==========================================
+ Hits 7729 7803 +74
- Misses 899 917 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 2 commits
September 29, 2025 18:38
OrientedBoundingBoxOrientedBoundingBox for spatial region analysis and particle selection
added 2 commits
September 30, 2025 11:37
svchb
previously approved these changes
Oct 2, 2025
added 2 commits
October 7, 2025 15:04
LasNikas
force-pushed
the
oriented-bbox
branch
from
October 7, 2025 13:07
59b2ee8 to
3c140db
Compare
LasNikas
force-pushed
the
oriented-bbox
branch
from
October 9, 2025 16:19
6b5d276 to
a6beb81
Compare
19 tasks
svchb
previously approved these changes
Oct 23, 2025
LasNikas
force-pushed
the
oriented-bbox
branch
from
October 27, 2025 16:56
63fa609 to
70860ad
Compare
LasNikas
force-pushed
the
oriented-bbox
branch
from
December 15, 2025 20:22
22d263a to
367e80a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an
OrientedBoundingBoxthat enables analysis of arbitrarily oriented rectangular regions within computational domains.For example: use
is_in_oriented_box(coords, box)to define measurement windows for calculating flow rates through specific cross-sections.Or for particle selection: using
intersect(ic::InitialCondition, box::OrientedBoundingBox...)- particularly useful for creating clamped particles for the TLSPH system.2D
3D
(hard to visualize but it's working)