Skip to content

Fix custom quantity reductions - #1184

Merged
efaulhaber merged 9 commits into
trixi-framework:mainfrom
svchb:fix/custom-quantities-active-particles
Aug 24, 2026
Merged

Fix custom quantity reductions#1184
efaulhaber merged 9 commits into
trixi-framework:mainfrom
svchb:fix/custom-quantities-active-particles

Conversation

@svchb

@svchb svchb commented May 12, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@svchb svchb self-assigned this May 12, 2026
@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.49%. Comparing base (02fc220) to head (693f6c2).

Files with missing lines Patch % Lines
test/general/custom_quantities.jl 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
- Coverage   90.50%   90.49%   -0.01%     
==========================================
  Files         141      141              
  Lines       11409    11419      +10     
==========================================
+ Hits        10326    10334       +8     
- Misses       1083     1085       +2     
Flag Coverage Δ
total 90.50% <90.90%> (-0.01%) ⬇️
unit 77.82% <90.90%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb svchb added the bug Something isn't working label May 12, 2026
@svchb
svchb requested a review from efaulhaber May 12, 2026 11:17

@efaulhaber efaulhaber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a NEWS.md entry.

Comment thread test/general/custom_quantities.jl Outdated
Comment thread src/general/custom_quantities.jl Outdated
@svchb
svchb requested a review from efaulhaber August 24, 2026 12:54
@efaulhaber

Copy link
Copy Markdown
Member

/run-gpu-tests

@efaulhaber
efaulhaber enabled auto-merge (squash) August 24, 2026 15:57
@efaulhaber
efaulhaber merged commit 4dd03d8 into trixi-framework:main Aug 24, 2026
18 of 19 checks passed
@svchb
svchb deleted the fix/custom-quantities-active-particles branch August 24, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants