Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
- Coverage 89.38% 89.34% -0.05%
==========================================
Files 121 121
Lines 8890 8903 +13
==========================================
+ Hits 7946 7954 +8
- Misses 944 949 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| using TrixiParticles | ||
|
|
||
| const TEST_AMBIGUITIES = let | ||
| value = lowercase(get(ENV, "TRIXIPARTICLES_TEST_AMBIGUITIES", "false")) |
There was a problem hiding this comment.
Why? How long do these tests take? Are they not fast enough to always include them?
Also, why is this not tested in CI?
There was a problem hiding this comment.
I fixed all problems that can be fixed easily. This fails with ambiguities that can only be fixed by:
- Modifying code that is imported
- Duplicating code that is imported
- Adding extensions to hide the imports
There was a problem hiding this comment.
Have you checked out the Trixi.jl version?
https://github.com/trixi-framework/Trixi.jl/blob/main/test/test_aqua.jl
They don't test for ambiguities at all. Maybe it makes sense to do the same and just remove the TRIXIPARTICLES_TEST_AMBIGUITIES altogether?
There was a problem hiding this comment.
Well practically I do the same. I just thought to keep it as an option.
| @@ -0,0 +1,9 @@ | |||
| using Aqua | |||
2 participants
No description provided.