Compute Normal Vectors for Boundary Particles#1036
Draft
RubberLanding wants to merge 17 commits intotrixi-framework:mainfrom
Draft
Compute Normal Vectors for Boundary Particles#1036RubberLanding wants to merge 17 commits intotrixi-framework:mainfrom
RubberLanding wants to merge 17 commits intotrixi-framework:mainfrom
Conversation
…kThe normals are not yet computed fot corner particles.
… tank do not exist.
Fix for the offset of the boundary normals.
…l cache. Create cache for Marrone. Rename the cache creation functions to be self-explanatory. Add `particle_volume` argument to `compute_wall_velocity()`.
Add test for normals in 3D. Update code for computing the normals for a sphere.
Add wrapper for InitialCondition again. Formatting.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
==========================================
+ Coverage 89.38% 89.66% +0.27%
==========================================
Files 121 121
Lines 8890 9159 +269
==========================================
+ Hits 7946 8212 +266
- Misses 944 947 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@efaulhaber Have a look please |
efaulhaber
requested changes
Jan 7, 2026
Member
efaulhaber
left a comment
efaulhaber
left a comment
There was a problem hiding this comment.
I haven't looked at the rectangular tank stuff yet.
Rename `compute_normals()` to `calculate_normals()`. Remove argument, whether to compute the normals for spheres and rectangular tanks (always gets computed), Add placeholder tests for sphere normals.
RubberLanding
force-pushed
the
BoundaryNormals
branch
from
49b6940 to
31e13ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute Normal Vectors for Boundary Particles. Used in the Boundary Condition by Marrone et al.