Add Carreau–Yasuda non-Newtonian viscosity model by sherin-joseph · Pull Request #1010 · trixi-framework/TrixiParticles.jl

sherin-joseph · 2025-12-04T17:19:19Z

modified:   src/TrixiParticles.jl
modified:   src/io/io.jl
modified:   src/schemes/fluid/viscosity.jl
modified:   test/schemes/fluid/viscosity.jl

modified: src/TrixiParticles.jl modified: src/io/io.jl modified: src/schemes/fluid/viscosity.jl modified: test/schemes/fluid/viscosity.jl

svchb · 2025-12-08T11:57:50Z

Please don't close and reopen the same PR when fixing review comments.

modified: docs/src/refs.bib modified: docs/src/systems/fluid.md modified: src/schemes/fluid/viscosity.jl

…iParticles.jl into non-newtonian

sherin-joseph · 2026-01-20T08:59:25Z

Ready for review @efaulhaber

docs/src/systems/fluid.md

src/schemes/fluid/viscosity.jl

test/schemes/fluid/viscosity.jl

codecov · 2026-01-20T13:21:56Z

Codecov Report

❌ Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.30%. Comparing base (67076da) to head (4707a38).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/io/io.jl	0.00%	9 Missing ⚠️
src/schemes/fluid/viscosity.jl	89.47%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
- Coverage   89.39%   89.30%   -0.10%     
==========================================
  Files         121      121              
  Lines        8889     8917      +28     
==========================================
+ Hits         7946     7963      +17     
- Misses        943      954      +11

Flag	Coverage Δ
total	`89.30% <60.71%> (-0.10%)`	⬇️
unit	`65.37% <60.71%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Sven Berger <[email protected]>

modified: docs/src/systems/fluid.md modified: src/schemes/fluid/viscosity.jl modified: test/schemes/fluid/viscosity.jl

sherin-joseph · 2026-01-28T15:15:26Z

Ready for re-review. @svchb

docs/src/systems/fluid.md

src/io/io.jl

src/schemes/fluid/viscosity.jl

Co-authored-by: Erik Faulhaber <[email protected]>

LasNikas · 2026-02-05T07:58:24Z

It would be nice to have an example file. Is there a corresponding validation in the literature to see the difference to Newtonian fluids?

sherin-joseph · 2026-02-06T13:07:55Z

It would be nice to have an example file. Is there a corresponding validation in the literature to see the difference to Newtonian fluids?

Yes—there's a corresponding validation case in the Vahabi paper mentioned in docs (bubble rise), which is used to highlight differences versus Newtonian behavior. I'm currently working on reproducing that setup and will share the example/inputs once it's in a clean, reusable form.

…iParticles.jl into non-newtonian

svchb · 2026-02-24T11:37:48Z

@sherin-joseph It never has been a good idea to put a new model and validation into the same PR since the validation takes so much longer. So we should move ahead with this first.

svchb · 2026-02-24T13:17:52Z

@sherin-joseph please reformat than we can merge this!

svchb · 2026-02-24T14:23:10Z

/run-gpu-tests

Changes to be committed:

ad4ebf3

modified: src/TrixiParticles.jl modified: src/io/io.jl modified: src/schemes/fluid/viscosity.jl modified: test/schemes/fluid/viscosity.jl

sherin-joseph marked this pull request as draft December 7, 2025 23:52

sherin-joseph and others added 3 commits December 11, 2025 14:53

Changes to be committed:

323f36a

modified: docs/src/refs.bib modified: docs/src/systems/fluid.md modified: src/schemes/fluid/viscosity.jl

Merge branch 'main' into non-newtonian

595abd7

Merge branch 'non-newtonian' of https://github.com/sherin-joseph/Trix…

54e57db

…iParticles.jl into non-newtonian

sherin-joseph marked this pull request as ready for review December 11, 2025 15:00

sherin-joseph added 2 commits December 16, 2025 13:23

Merge branch 'main' into non-newtonian

4232251

Merge branch 'main' into non-newtonian

00c3f13

sherin-joseph marked this pull request as draft January 15, 2026 14:12

sherin-joseph marked this pull request as ready for review January 15, 2026 14:42

Merge branch 'main' into non-newtonian

3e61713

svchb assigned sherin-joseph Jan 20, 2026

svchb added the enhancement New feature or request label Jan 20, 2026

svchb requested review from efaulhaber and svchb January 20, 2026 09:01

svchb requested changes Jan 20, 2026

View reviewed changes

sherin-joseph and others added 3 commits January 20, 2026 14:47

Update docs/src/systems/fluid.md

c447fd0

Co-authored-by: Sven Berger <[email protected]>

Merge branch 'trixi-framework:main' into non-newtonian

4d52f3e

modified: docs/src/refs.bib

8e8f0d5

modified: docs/src/systems/fluid.md modified: src/schemes/fluid/viscosity.jl modified: test/schemes/fluid/viscosity.jl

svchb self-requested a review February 2, 2026 14:43

svchb previously approved these changes Feb 2, 2026

View reviewed changes

svchb and others added 2 commits February 2, 2026 15:45

Merge branch 'main' into non-newtonian

c6270e8

Merge branch 'trixi-framework:main' into non-newtonian

42ca215

efaulhaber requested changes Feb 4, 2026

View reviewed changes

docs/src/systems/fluid.md Outdated Show resolved Hide resolved

src/io/io.jl Show resolved Hide resolved

src/schemes/fluid/viscosity.jl Outdated Show resolved Hide resolved

Update docs/src/systems/fluid.md

c0fbe20

Co-authored-by: Erik Faulhaber <[email protected]>

sherin-joseph dismissed svchb’s stale review via c0fbe20 February 4, 2026 15:06

sherin-joseph and others added 2 commits February 4, 2026 16:06

Update src/io/io.jl

0ebbd4f

Co-authored-by: Erik Faulhaber <[email protected]>

Update src/schemes/fluid/viscosity.jl

dd1e343

Co-authored-by: Erik Faulhaber <[email protected]>

sherin-joseph and others added 7 commits February 17, 2026 12:20

new file: examples/fluid/bubble_rise_carreau_yasuda.jl

b9b25aa

Update comment for bubble_rise_carreau_yasuda.jl

5595f3f

Delete examples/fluid/bubble_rise_carreau_yasuda.jl

e99644f

new file: examples/fluid/bubble_rise.jl

7fa1921

Merge branch 'non-newtonian' of https://github.com/sherin-joseph/Trix…

d88f1d6

…iParticles.jl into non-newtonian

Merge branch 'trixi-framework:main' into non-newtonian

b1d7ca5

Merge branch 'non-newtonian' of https://github.com/sherin-joseph/Trix…

e21a366

…iParticles.jl into non-newtonian

sherin-joseph requested review from efaulhaber and svchb February 17, 2026 15:54

sherin-joseph marked this pull request as draft February 19, 2026 08:18

Delete examples/fluid/bubble_rise.jl

c7ece49

svchb marked this pull request as ready for review February 24, 2026 11:36

Merge branch 'main' into non-newtonian

7b7a0a7

svchb previously approved these changes Feb 24, 2026

View reviewed changes

efaulhaber previously approved these changes Feb 24, 2026

View reviewed changes

Format: automatic style check fixes

4388338

sherin-joseph dismissed stale reviews from efaulhaber and svchb via 4388338 February 24, 2026 14:08

Merge branch 'main' into non-newtonian

4707a38

svchb approved these changes Feb 24, 2026

View reviewed changes

svchb enabled auto-merge (squash) February 24, 2026 14:23

svchb merged commit 0acb886 into trixi-framework:main Feb 24, 2026
16 of 18 checks passed

Conversation

sherin-joseph commented Dec 4, 2025

Uh oh!

svchb commented Dec 8, 2025

Uh oh!

sherin-joseph commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sherin-joseph commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LasNikas commented Feb 5, 2026

Uh oh!

sherin-joseph commented Feb 6, 2026

Uh oh!

svchb commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svchb commented Feb 24, 2026

Uh oh!

svchb commented Feb 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 20, 2026 •

edited

Loading

svchb commented Feb 24, 2026 •

edited

Loading