Add Carreau–Yasuda non-Newtonian viscosity model#1010
Add Carreau–Yasuda non-Newtonian viscosity model#1010sherin-joseph wants to merge 15 commits intotrixi-framework:mainfrom
Conversation
sherin-joseph
commented
Dec 4, 2025
modified: src/TrixiParticles.jl modified: src/io/io.jl modified: src/schemes/fluid/viscosity.jl modified: test/schemes/fluid/viscosity.jl
|
Please don't close and reopen the same PR when fixing review comments. |
modified: docs/src/refs.bib modified: docs/src/systems/fluid.md modified: src/schemes/fluid/viscosity.jl
|
Ready for review @efaulhaber |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
- Coverage 89.40% 89.31% -0.10%
==========================================
Files 121 121
Lines 8882 8910 +28
==========================================
+ Hits 7941 7958 +17
- Misses 941 952 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Sven Berger <[email protected]>
modified: docs/src/systems/fluid.md modified: src/schemes/fluid/viscosity.jl modified: test/schemes/fluid/viscosity.jl
|
Ready for re-review. @svchb |
Co-authored-by: Erik Faulhaber <[email protected]>
Co-authored-by: Erik Faulhaber <[email protected]>
Co-authored-by: Erik Faulhaber <[email protected]>
|
It would be nice to have an example file. Is there a corresponding validation in the literature to see the difference to Newtonian fluids? |
Yes—there's a corresponding validation case in the Vahabi paper mentioned in docs (bubble rise), which is used to highlight differences versus Newtonian behavior. I'm currently working on reproducing that setup and will share the example/inputs once it's in a clean, reusable form. |