Skip to content

Test Ignite handling of decimal type with negative scale#28631

Closed
zheliu2 wants to merge 1 commit intotrinodb:masterfrom
zheliu2:zheliu/test-ignite-decimal-negative-scale
Closed

Test Ignite handling of decimal type with negative scale#28631
zheliu2 wants to merge 1 commit intotrinodb:masterfrom
zheliu2:zheliu/test-ignite-decimal-negative-scale

Conversation

@zheliu2
Copy link
Copy Markdown

@zheliu2 zheliu2 commented Mar 12, 2026

Description

Add test coverage for Ignite connector handling of decimal columns with negative scale.

IgniteClient.toColumnMapping has code at line 253 that claims to support mapping decimal(p, -s) to decimal(p+s, 0), but this code path is untested.

This PR adds testDecimalNegativeScale() to TestIgniteTypeMapping following the same pattern established in #28414 for the PostgreSQL connector.

Additional context and related issues

Release notes

( ) This is not user-visible or docs-only

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 12, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the ignite Ignite connector label Mar 12, 2026
@zheliu2 zheliu2 closed this Mar 12, 2026
@zheliu2 zheliu2 deleted the zheliu/test-ignite-decimal-negative-scale branch March 12, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignite Ignite connector

Development

Successfully merging this pull request may close these issues.

Test Ignite handling of decimal type with negative scale

1 participant