Reduce synchronized lock on DirectExchangeClient scheduling#28391
Open
jinyangli34 wants to merge 1 commit intotrinodb:masterfrom
Open
Reduce synchronized lock on DirectExchangeClient scheduling#28391jinyangli34 wants to merge 1 commit intotrinodb:masterfrom
jinyangli34 wants to merge 1 commit intotrinodb:masterfrom
Conversation
Original logic locks entire pick + schedule loop. New logic locks each dequeue individually, allow other threads to grab lock in middle
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Original logic locks entire dequeue + schedule loop.
New logic locks each dequeue individually, allow other threads to grab lock in middle
Additional context and related issues
Often seeing threads blocked on
DirectExchangeClient::scheduleRequestIfNecessaryRelease notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: