WIP: Grow VariableWithBlockBuilder by average position size#28378
Open
WIP: Grow VariableWithBlockBuilder by average position size#28378
Conversation
pettyjamesm
reviewed
Feb 20, 2026
| // proactively grow bytes array based on observed average entry size | ||
| int currentBytes = offsets[positionCount]; | ||
| if (positionCount > 0 && currentBytes > 0) { | ||
| int averageBytesPerEntry = currentBytes / positionCount; |
Member
There was a problem hiding this comment.
Consider using double instead of integer division. The rounding down behavior seems likely to result in underestimating the target size in most cases which will require another growing copy.
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: