Skip to content

Add support for ±Infinity and NaN in NUMBER#28219

Merged
findepi merged 5 commits intotrinodb:masterfrom
findepi:findepi/bd-nan
Feb 19, 2026
Merged

Add support for ±Infinity and NaN in NUMBER#28219
findepi merged 5 commits intotrinodb:masterfrom
findepi:findepi/bd-nan

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Feb 10, 2026

Extend NUMBER type to allow representing positive/negative
infinity and not-a-number values.

This will allow e.g. the following:

  • safely convert all values of real and double to number
  • read PostgreSQL's decimal values (PostgreSQL decimal can hold
    infinity, and the unconstrained decimal (with dynamic scale) can also
    hold not-a-number)

.

Release notes

not for release notes yet

@cla-bot cla-bot bot added the cla-signed label Feb 10, 2026
@findepi findepi force-pushed the findepi/bd-nan branch 2 times, most recently from 58a0098 to c222713 Compare February 10, 2026 15:49
@github-actions github-actions bot added jdbc Relates to Trino JDBC driver iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector bigquery BigQuery connector mongodb MongoDB connector cassandra Cassandra connector blackhole Blackhole connector elasticsearch Elasticsearch connector faker Faker connector kafka Kafka connector memory Memory connector opensearch OpenSearch connector pinot Pinot connector prometheus Prometheus connector redis Redis connector labels Feb 10, 2026
@findepi findepi force-pushed the findepi/bd-nan branch 2 times, most recently from 0f5a315 to 8975120 Compare February 13, 2026 14:39
@findepi findepi added no-release-notes This pull request does not require release notes entry and removed bigquery BigQuery connector mongodb MongoDB connector cassandra Cassandra connector blackhole Blackhole connector elasticsearch Elasticsearch connector faker Faker connector kafka Kafka connector memory Memory connector opensearch OpenSearch connector pinot Pinot connector prometheus Prometheus connector redis Redis connector labels Feb 17, 2026
@github-actions github-actions bot added jdbc Relates to Trino JDBC driver delta-lake Delta Lake connector labels Feb 18, 2026
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Feb 18, 2026

Some preparatory test improvements extracted to

`TypeUtils.typeHasNaN` nicely complements
`TypeUtils.isFloatingPointNaN`.
Retain String on-the-wire representation and decode directly to demanded
type.
Extend `NUMBER` type to allow representing positive/negative
infinity and not-a-number values.

This will allow e.g. the following:

- safely convert all values of `real` and `double` to `number`
- read PostgreSQL's `decimal` values (PostgreSQL `decimal` can hold
  infinity, and the unconstrained decimal (with dynamic scale) can also
  hold not-a-number)
@findepi findepi merged commit f22a524 into trinodb:master Feb 19, 2026
202 of 204 checks passed
@findepi findepi deleted the findepi/bd-nan branch February 19, 2026 12:04
@ebyhr ebyhr mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed delta-lake Delta Lake connector jdbc Relates to Trino JDBC driver no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

4 participants