Brainfart: switch(get_value(), v -> if(v = 1, 'First'), v -> if(v = 2, 'Second', 'Default'))#28152
Closed
gertjanal wants to merge 1 commit intotrinodb:masterfrom
Closed
Brainfart: switch(get_value(), v -> if(v = 1, 'First'), v -> if(v = 2, 'Second', 'Default'))#28152gertjanal wants to merge 1 commit intotrinodb:masterfrom
gertjanal wants to merge 1 commit intotrinodb:masterfrom
Conversation
…'Second', 'Default'))
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch cases in a single expression are usually written like this:
CASE get_value() WHEN v = 1 THEN 'First' WHEN v = 2 THEN 'Second' ELSE 'Default' ENDWith the function of this PR, the expression can be written like this:
switch(get_value(), v -> if(v = 1, 'First'), v -> if(v = 2, 'Second', 'Default'))It is shorter, but also allows more complex implementations like:
v -> if(is_valid_value(v), 'First')or
v -> if(v = 2 OR v = 3, 'Second'):switch(get_value(), v -> if(is_valid_value(v), 'First'), v -> if(v = 2 OR v = 3, 'Second', 'Default'))I wonder if anyone sees any potential in this function. It was fun to implement it. When a case returns
NULL, the next case is tested.Release notes
I'll add this later when the PR is approved