Merged
Conversation
findepi
force-pushed
the
findepi/bd-jdbc
branch
from
fe1cb57 to
4922469
Compare
findepi
force-pushed
the
findepi/bd-jdbc
branch
2 times, most recently
from
040cb09 to
7825cb3
Compare
Contributor
|
Drop merge commit |
findepi
force-pushed
the
findepi/bd-jdbc
branch
from
7825cb3 to
673ea9c
Compare
26 tasks
findepi
force-pushed
the
findepi/bd-jdbc
branch
from
673ea9c to
7dff2a6
Compare
Member
Author
|
rebased after these merged |
findepi
commented
Feb 17, 2026
client/trino-jdbc/src/test/java/io/trino/jdbc/BaseTestJdbcResultSet.java
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/bd-jdbc
branch
from
7dff2a6 to
98d7642
Compare
losipiuk
reviewed
Feb 17, 2026
losipiuk
approved these changes
Feb 17, 2026
Member
losipiuk
left a comment
losipiuk
left a comment
There was a problem hiding this comment.
fix assertions faiilures are relevant
wendigo
approved these changes
Feb 17, 2026
findepi
force-pushed
the
findepi/bd-jdbc
branch
from
98d7642 to
3ad5596
Compare
It's mapped to `Types.OTHER` type. Mapping to `Types.DECIMAL` and `Types.NUMERIC` seems more appropriate for SQL `decimal` and `numeric` types respectively (Trino doesn't have SQL standard `numeric` yet), and may be taken as a signal that `ResultSet.getBigDecimal` is the best way to access the data. Its Java class, as returned from `ResultSetMetaData.getColumnClassName`, is `java.lang.Number`, because the `ResultSet.getObject` typically returns `java.math.BigDecimal` but sometimes also returns/will return `java.lang.Double` for Infinity and NaN values.
findepi
force-pushed
the
findepi/bd-jdbc
branch
from
3ad5596 to
4103f93
Compare
findepi
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's mapped to
Types.OTHERtype. Mapping toTypes.DECIMALandTypes.NUMERICseems more appropriate for SQLdecimalandnumerictypes respectively (Trino doesn't have SQL standard
numericyet), andmay be taken as a signal that
ResultSet.getBigDecimalis the best wayto access the data.
Its Java class, as returned from
ResultSetMetaData.getColumnClassName,is
java.lang.Number, because theResultSet.getObjecttypicallyreturns
java.math.BigDecimalbut sometimes also returns/will returnjava.lang.Doublefor Infinity and NaN values..
Release notes
not for release notes yet